tensorflow / tfx-addons

Developers helping developers. TFX-Addons is a collection of community projects to build new components, examples, libraries, and tools for TFX. The projects are organized under the auspices of the special interest group, SIG TFX-Addons. Join the group at http://goo.gle/tfx-addons-group
Apache License 2.0
125 stars 64 forks source link

Move MCT component to TFX Addons #196

Closed hanneshapke closed 1 year ago

hanneshapke commented 2 years ago

Addresses #82

github-actions[bot] commented 2 years ago

Thanks for the PR! :rocket:

Instructions: Approve using /lgtm and mark for automatic merge by using /merge.

hanneshapke commented 2 years ago

@codesue Let's chat async what to do with https://github.com/tensorflow/model-card-toolkit/blob/master/model_card_toolkit/utils/tfx_util.py and the related tests. Are there reasons for it to stay in the MCT repo?

hanneshapke commented 2 years ago

I think it should probably stay. It is used in core and it seems to contain the connector pieces to the TFX libraries, not the component par se.

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

codesue commented 2 years ago

Let's chat async what to do with https://github.com/tensorflow/model-card-toolkit/blob/master/model_card_toolkit/utils/tfx_util.py and the related tests.

This might be good to consider as part of https://github.com/tensorflow/model-card-toolkit/discussions/228. I wonder if it's feasible to move functionality specific to pipelines and mlmd to the component's new home and the mlmd client library respectively but keep functions that only used tfma, tfdv, etc. If so, we could make tfx and mlmd utils available through a [tfx] extra, for example.

codesue commented 1 year ago

/lgtm

github-actions[bot] commented 1 year ago

Approval received from @codesue! :white_check_mark:

PR is approved. Missing merge command to auto-merge PR!

hanneshapke commented 1 year ago

Thank you @codesue

hanneshapke commented 1 year ago

/merge

github-actions[bot] commented 1 year ago

Merged with approvals from codesue and rcrowe-google - thanks for the contribution! :tada: