search

tensorflow / tfx-addons

Developers helping developers. TFX-Addons is a collection of community projects to build new components, examples, libraries, and tools for TFX. The projects are organized under the auspices of the special interest group, SIG TFX-Addons. Join the group at http://goo.gle/tfx-addons-group
Apache License 2.0
125 stars 64 forks source link

fix: filter non-text files for text replacement #197

Closed deep-diver closed 2 years ago

deep-diver commented 2 years ago

I found a bug in the HFPusher component that tries to replace contents in a file with given text even if the file is a binary type. This causes an error, so I have added a simple filtering logic to identify only text based files.

github-actions[bot] commented 2 years ago

Thanks for the PR! :rocket:

Instructions: Approve using /lgtm and mark for automatic merge by using /merge.

deep-diver commented 2 years ago

@casassg

Could you take a look on this?

deep-diver commented 2 years ago

@codesue

addressed your comment!

codesue commented 2 years ago

Approved, but it looks like I can't unblock merging. @sayakpaul might be able to.

casassg commented 2 years ago

/lgtm yes @sayakpaul will need to approve most likely

deep-diver commented 2 years ago

@sayakpaul

Could take a look into this PR? Actually, this is basically a copy of the bug fixing from our recent project.

sayakpaul commented 2 years ago

/lgtm

Thanks for the fix.

sayakpaul commented 2 years ago

/approve

github-actions[bot] commented 2 years ago

Approval received from @sayakpaul! :white_check_mark:

PR is approved. Missing merge command to auto-merge PR!

sayakpaul commented 2 years ago

/merge

github-actions[bot] commented 2 years ago

Merged with approvals from sayakpaul - thanks for the contribution! :tada: