Closed cfezequiel closed 1 year ago
Thanks for the PR! :rocket:
Instructions: Approve using /lgtm
and mark for automatic merge by using /merge
.
@hanneshapke @rcrowe-google if the PR looks good I was wondering if we could already merge it. I'd like to raise a subsequent PR for further code changes to the component.
@cfezequiel I am sorry, I won't have a chance to review the PR in detail. A brief review looked good, but the PR is a bigger rewrite than what I can handle after work at the moment. I am sorry.
@cfezequiel Just did another pass over the PR. Could you please remove my email address from the files. Can you leave my name and add my affiliation please (e.g. Hannes Hapke (Digits Financial Inc.)
)? Thank you.
Happy to stamp / merge afterward.
@cfezequiel Just did another pass over the PR. Could you please remove my email address from the files. Can you leave my name and add my affiliation please (e.g.
Hannes Hapke (Digits Financial Inc.)
)? Thank you.Happy to stamp / merge afterward.
@hanneshapke Sure, done.
/lgtm
@cfezequiel Thank you.
Approval received from @hanneshapke! :white_check_mark:
PR is approved. Missing merge command to auto-merge PR!
/merge
Merged with approvals from hanneshapke - thanks for the contribution! :tada:
Thanks for the approval and merge @hanneshapke .
Fixes #221
Refactors executor.py
Adds unit tests
Adds credits to original code author
[ X ] Tests pass