tensorflow / tfx-addons

Developers helping developers. TFX-Addons is a collection of community projects to build new components, examples, libraries, and tools for TFX. The projects are organized under the auspices of the special interest group, SIG TFX-Addons. Join the group at http://goo.gle/tfx-addons-group
Apache License 2.0
125 stars 64 forks source link

Feature/pred2bq executor refactor #222

Closed cfezequiel closed 1 year ago

cfezequiel commented 1 year ago

Fixes #221

github-actions[bot] commented 1 year ago

Thanks for the PR! :rocket:

Instructions: Approve using /lgtm and mark for automatic merge by using /merge.

cfezequiel commented 1 year ago

@hanneshapke @rcrowe-google if the PR looks good I was wondering if we could already merge it. I'd like to raise a subsequent PR for further code changes to the component.

hanneshapke commented 1 year ago

@cfezequiel I am sorry, I won't have a chance to review the PR in detail. A brief review looked good, but the PR is a bigger rewrite than what I can handle after work at the moment. I am sorry.

hanneshapke commented 1 year ago

@cfezequiel Just did another pass over the PR. Could you please remove my email address from the files. Can you leave my name and add my affiliation please (e.g. Hannes Hapke (Digits Financial Inc.))? Thank you.

Happy to stamp / merge afterward.

cfezequiel commented 1 year ago

@cfezequiel Just did another pass over the PR. Could you please remove my email address from the files. Can you leave my name and add my affiliation please (e.g. Hannes Hapke (Digits Financial Inc.))? Thank you.

Happy to stamp / merge afterward.

@hanneshapke Sure, done.

hanneshapke commented 1 year ago

/lgtm

hanneshapke commented 1 year ago

@cfezequiel Thank you.

github-actions[bot] commented 1 year ago

Approval received from @hanneshapke! :white_check_mark:

PR is approved. Missing merge command to auto-merge PR!

hanneshapke commented 1 year ago

/merge

github-actions[bot] commented 1 year ago

Merged with approvals from hanneshapke - thanks for the contribution! :tada:

cfezequiel commented 1 year ago

Thanks for the approval and merge @hanneshapke .