tensorflow / tfx-addons

Developers helping developers. TFX-Addons is a collection of community projects to build new components, examples, libraries, and tools for TFX. The projects are organized under the auspices of the special interest group, SIG TFX-Addons. Join the group at http://goo.gle/tfx-addons-group
Apache License 2.0
125 stars 61 forks source link

pred2bq: Update schema parsing from prediction results. #225

Closed cfezequiel closed 1 year ago

cfezequiel commented 1 year ago

Related to #78

Update code to enable schema parsing from BulkInferrer prediction results data directly. This adds a third option to the existing ways to parse the input data schema, which include:

  1. Parsing from schema.pbtxt file
  2. Parsing from TFTransform output path (generated by the TFX Transform component).

Additional changes:

github-actions[bot] commented 1 year ago

Thanks for the PR! :rocket:

Instructions: Approve using /lgtm and mark for automatic merge by using /merge.

cfezequiel commented 1 year ago

Hi @hanneshapke, I was wondering if you'll be able to review this PR. Sorry for the long-ish change, but it's a bit of a challenge now to break it up into smaller chunks due to time constraints, and subsequent changes also build on top of this PR.

With that said, an alternative would be for me to submit one large PR containing all the subsequent changes for the component. Pro: One PR to review; total LOC change may be lower than the sum of subsequent PRs due to merging of overlapping changes. Con: PR would be larger than the previous ones.

Let me know what you think.

cfezequiel commented 1 year ago

This can be deprecated in favor of #230 , which also contains the changes here.

hanneshapke commented 1 year ago

Closing it by request from @michaelwsherman