tensorflow / tfx-addons

Developers helping developers. TFX-Addons is a collection of community projects to build new components, examples, libraries, and tools for TFX. The projects are organized under the auspices of the special interest group, SIG TFX-Addons. Join the group at http://goo.gle/tfx-addons-group
Apache License 2.0
125 stars 64 forks source link

Enable filtering features and metrics in the ModelCardGenerator #256

Closed codesue closed 1 year ago

codesue commented 1 year ago

Model Card Toolkit supports filtering features and metrics when annotating a model card. This change surfaces features_include, features_exclude, metrics_include, and metrics_exclude parameters to enable filtering features and metrics through the ModelCardGenerator component as well.

Fixes issue reported in the tfxa Google Group.

github-actions[bot] commented 1 year ago

Thanks for the PR! :rocket:

Instructions: Approve using /lgtm and mark for automatic merge by using /merge.

codesue commented 1 year ago

It LGTM, but I don't know this code well enough to really be sure.

Thanks for the review, Robert! In that case, maybe @hanneshapke can take a look before merging this.

codesue commented 1 year ago

/merge

casassg commented 1 year ago

/merge

casassg commented 1 year ago

/merge again bc I had to fix a small part in automerge bot

github-actions[bot] commented 1 year ago

Merged with approvals from rcrowe-google - thanks for the contribution! :tada: