Support remote storage in modelcardgenerator

tensorflow / tfx-addons

Developers helping developers. TFX-Addons is a collection of community projects to build new components, examples, libraries, and tools for TFX. The projects are organized under the auspices of the special interest group, SIG TFX-Addons. Join the group at http://goo.gle/tfx-addons-group

Apache License 2.0

125 stars 64 forks source link

Support remote storage in modelcardgenerator #262

Closed jeongukjae closed 1 year ago

jeongukjae commented 1 year ago

Fixes #261

I updated the MCT generator to create a temp dir for all cases since I don't think that's a big operation.

[x] Tests pass
[ ] Appropriate changes to README are included in PR

github-actions[bot] commented 1 year ago

Thanks for the PR! :rocket:

Instructions: Approve using /lgtm and mark for automatic merge by using /merge.

codesue commented 1 year ago

Hi @rcrowe-google or @casassg, would you please take a look at this PR since Hannes is currently unavailable. 🙏

codesue commented 1 year ago

Thank you, Robert! My apologies; I think I blanked and forgot about the bot. I'll be more mindful about this next time. 😅

casassg commented 1 year ago

btw just a heads up. The bot adds and removes labels in the PR as needed. if it has lgtm, then only is missing / merge command

codesue commented 1 year ago

/merge

github-actions[bot] commented 1 year ago

Merged with approvals from codesue - thanks for the contribution! :tada: