search

tensorflow / tfx-addons

Developers helping developers. TFX-Addons is a collection of community projects to build new components, examples, libraries, and tools for TFX. The projects are organized under the auspices of the special interest group, SIG TFX-Addons. Join the group at http://goo.gle/tfx-addons-group
Apache License 2.0
125 stars 64 forks source link

How about adding rcParams argument in ModelCardGenerator #263

Open jeongukjae opened 1 year ago

jeongukjae commented 1 year ago

For non-English projects, it is essential to change the font configs to render graphics properly. If cannot, the graphics in the model card looks as follows:

test

So, it could be great if ModelCardGenerator can accept the argument like 'matplotlib_rcparams'.

mc_gen = ModelCardGenerator(
  pushed_model=...,
  ...
  ...
  matplotlib_rcparams=json.dumps({
    "font.family": "NanumGothic",
    ...
  }),
)

mentioning code owners of ModelCardGenerator @codesue @hanneshapke

codesue commented 1 year ago

Great idea! In addition to supporting other languages, it would be nice to be able to customize the plots.

jeongukjae commented 1 year ago

@codesue Oh, it would be great if that's possible. I think that is another topic, so I'm leaving that at https://github.com/tensorflow/model-card-toolkit/discussions/296