Open casassg opened 3 years ago
I think the formatters you added are pretty standard, so we could have the same pre-submit hook for folders under examples too, with opt-out option (rather than opt-in).
Sure. We would need buy-in from @TheMichaelHu to see if we can apply the same formatters in sklearn project
AS a followup conversation with @TheMichaelHu in https://github.com/tensorflow/tfx-addons/pull/43#discussion_r672664148 How should we set up CI?
For now here's what I added on pre-submit for anything under tfx_addons:
Reasoning to not add to folders under examples:
Also, added pytest automatic run for jobs added to tfx_addons. I didnt add examples to pytest to avoid issues on different configurations.
What are people thoughts on wether all those tests are enough/too much? Wether we should enable pre-submit-hook for examples folders?
Overall, took a fast opinionated stance to get something working for now, but would be interested on feedback or on wether we should change things here.