tensorflow / tfx-addons

Developers helping developers. TFX-Addons is a collection of community projects to build new components, examples, libraries, and tools for TFX. The projects are organized under the auspices of the special interest group, SIG TFX-Addons. Join the group at http://goo.gle/tfx-addons-group
Apache License 2.0
125 stars 63 forks source link

[Discussion] How should we use CI for repo? #45

Open casassg opened 3 years ago

casassg commented 3 years ago

AS a followup conversation with @TheMichaelHu in https://github.com/tensorflow/tfx-addons/pull/43#discussion_r672664148 How should we set up CI?

For now here's what I added on pre-submit for anything under tfx_addons:

Reasoning to not add to folders under examples:

Also, added pytest automatic run for jobs added to tfx_addons. I didnt add examples to pytest to avoid issues on different configurations.

What are people thoughts on wether all those tests are enough/too much? Wether we should enable pre-submit-hook for examples folders?

Overall, took a fast opinionated stance to get something working for now, but would be interested on feedback or on wether we should change things here.

vincentxed commented 3 years ago

I think the formatters you added are pretty standard, so we could have the same pre-submit hook for folders under examples too, with opt-out option (rather than opt-in).

casassg commented 3 years ago

Sure. We would need buy-in from @TheMichaelHu to see if we can apply the same formatters in sklearn project