tensorflow / tfx

TFX is an end-to-end platform for deploying production ML pipelines
https://tensorflow.github.io/tfx/
Apache License 2.0
2.11k stars 708 forks source link

Get cached outputs loads the first artifact w matching properties, instead of latest artifact w matching properties #3827

Closed casassg closed 1 year ago

casassg commented 3 years ago

System information

Describe the current behavior

If you force reexecution of a component (enable_cache=False), and then use cache, it loads the first existing output artifact with matching properties. See https://colab.research.google.com/drive/1yLt_adE-s-IVLQ_uzPmuyr3ejDbLQT2T?usp=sharing (1st execution creates artifact 1, second execution creates artifact 2, third execution returns artifact 1).

Describe the expected behavior

I would expect to be able to overwrite the cache by forcing reexecution. This means that third execution should load artifact 2 instead of artifact 1.

Standalone code to reproduce the issue

https://colab.research.google.com/drive/1yLt_adE-s-IVLQ_uzPmuyr3ejDbLQT2T?usp=sharing

Name of your Organization (Optional)

Twitter

arghyaganguly commented 3 years ago

update

step: Download the dataset

DATA_PATH = 'https://raw.githubusercontent.com/tensorflow/tfx/master/tfx/examples/penguin/data/labelled/penguins_processed.csv' 

PR for fix.

@casassg , thanks for reporting this issue, which i was able to reproduce with slight variation to highlight more on the behaviour in the github gist.

google-ml-butler[bot] commented 3 years ago

Are you satisfied with the resolution of your issue? Yes No

casassg commented 3 years ago

I believe issue was not fixed. There was only a small fix of a data path

singhniraj08 commented 1 year ago

Hi @casassg,

Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.

The TFX team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TFX version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.

Please follow the release notes to stay up to date with the latest developments which are happening in the TFX space. Thank you!

github-actions[bot] commented 1 year ago

This issue has been marked stale because it has no recent activity since 7 days. It will be closed if no further activity occurs. Thank you.

github-actions[bot] commented 1 year ago

This issue was closed due to lack of activity after being marked stale for past 7 days.

github-actions[bot] commented 1 year ago

Are you satisfied with the resolution of your issue? Yes No