tensorflow / tpu

Reference models and tools for Cloud TPUs.
https://cloud.google.com/tpu/
Apache License 2.0
5.21k stars 1.77k forks source link

Fixed broken shakespeare_with_tpu_and_keras.ipynb example #1026

Open dcerisano opened 1 year ago

dcerisano commented 1 year ago

Not sure why this example is now broken on Colab. Thinking version control problem between numpy and tensorflow.

Essentially, the shape of the numpy prediction array is inconsistent, and is now being rejected by tensorflow's prediction method.

In the current version of the example, prediction breaks on the second prediction because it is expecting an array of single ascii value arrays (like the first seeded input).

However the array that is appended for the next prediction is just an array of ascii values, which causes the predict function to throw an error.

Also, the printing section is expecting an array of ascii values instead of the array of single value ascii arrays used for storing predictions.

The fixes are minor, simply making sure each character is created as a single ascii value array, and then indexed that way during printing of results.

Side note: I got much better results by increasing (4X) the number of epochs, step size and embedding dimensions during training. Results in a much higher resolution weights file that produces much more cogent outputs.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB