search

tensorflow / transform

Input pipeline framework
Apache License 2.0
984 stars 214 forks source link

examples/README.md has dead link to getting started #272

Open pritamdodeja opened 2 years ago

pritamdodeja commented 2 years ago

I have submitted pr269 with a fix to point it to here. It currently points here which gives a 404.

pindinagesh commented 2 years ago

Hi @pritamdodeja

I have assigned a reviewer to your PR, Could you please send the source page link where you got 404 error link will look into it. Thanks!

pritamdodeja commented 2 years ago

Thanks @pindinagesh It's at https://github.com/tensorflow/transform/blob/master/examples/README.md in the Census Income Example section. It says 'Get started with TensorFlow Transform', and points to a dead location.

pindinagesh commented 2 years ago

Hi @pritamdodeja

I went through the link which you provided for a broken link that was appropriate, the issue will be closed once it gets merged. Thanks!

pritamdodeja commented 2 years ago

Thanks @pindinagesh! In a conversation with zoyahav on this, I mentioned the following:

what do you think about featuring the getting started notebook more prominently off of https://github.com/tensorflow/transform/blob/master/README.md itself, and making it a relative reference so that anybody that clones the repo can try it out locally?

It's a great starter notebook but it's pretty hidden. If it was made a relative reference, anybody can clone the repo locally and directly run it in jupyter lab from README.md.

Thank you for your help!