search

tensorly / tensorly

TensorLy: Tensor Learning in Python.
http://tensorly.org
Other
1.56k stars 289 forks source link

partial_tucker: reorder arguments #237

Closed JeanKossaifi closed 2 years ago

JeanKossaifi commented 3 years ago

Currently modes is a positional argument while rank is optional, this can be confusing and not consistent with other decompositions.

https://github.com/tensorly/tensorly/blob/d8e90a600c3c26983777e971ce85ccba071cdfaf/tensorly/decomposition/_tucker.py#L16

JeanKossaifi commented 2 years ago

Fixed in #418