Closed JeanKossaifi closed 2 years ago
Currently modes is a positional argument while rank is optional, this can be confusing and not consistent with other decompositions.
https://github.com/tensorly/tensorly/blob/d8e90a600c3c26983777e971ce85ccba071cdfaf/tensorly/decomposition/_tucker.py#L16
Fixed in #418
Currently modes is a positional argument while rank is optional, this can be confusing and not consistent with other decompositions.
https://github.com/tensorly/tensorly/blob/d8e90a600c3c26983777e971ce85ccba071cdfaf/tensorly/decomposition/_tucker.py#L16