search

tensorly / tensorly

TensorLy: Tensor Learning in Python.
http://tensorly.org
Other
1.51k stars 281 forks source link

Fully deprecate mxnet #532

Closed aarmey closed 7 months ago

aarmey commented 7 months ago

The mxnet project has been formally archived. Therefore, I think it is reasonable to fully deprecate mxnet, before it stops working on various new Python and numpy versions.

I will also open a draft PR for removing mxnet that we can keep open until a new TensorLy version is issued.

Searching on Github, I only found mxnet being used in copies of the tutorials and one project that tests against all backends, so I think that the impact will be minimal.

codecov[bot] commented 7 months ago

Codecov Report

Merging #532 (dac438b) into main (357aa66) will increase coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #532      +/-   ##
==========================================
+ Coverage   87.06%   87.08%   +0.01%     
==========================================
  Files         121      121              
  Lines        7703     7703              
==========================================
+ Hits         6707     6708       +1     
+ Misses        996      995       -1

see 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

JeanKossaifi commented 7 months ago

Thank you @aarmey - I agree! PR looks good to me, merging.

JeanKossaifi commented 7 months ago

I guess we can start thinking about what to do with TensorFlow too..