search

tensorly / tensorly

TensorLy: Tensor Learning in Python.
http://tensorly.org
Other
1.51k stars 281 forks source link

Remove mxnet #533

Closed aarmey closed 4 months ago

aarmey commented 7 months ago

This removes mxnet as a backend, since development has halted.

codecov[bot] commented 7 months ago

Codecov Report

Merging #533 (9c82c5e) into main (357aa66) will decrease coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
- Coverage   87.06%   87.05%   -0.02%     
==========================================
  Files         121      121              
  Lines        7703     7693      -10     
==========================================
- Hits         6707     6697      -10     
  Misses        996      996
Files Coverage Δ
tensorly/backend/__init__.py 89.83% <100.00%> (ø)
tensorly/contrib/decomposition/_tt_cross.py 88.95% <ø> (ø)
...ecomposition/tests/test_mps_decomposition_cross.py 100.00% <ø> (ø)
tensorly/cp_tensor.py 84.28% <ø> (ø)
tensorly/decomposition/_cp.py 83.71% <ø> (ø)
tensorly/decomposition/robust_decomposition.py 97.29% <ø> (-0.08%) :arrow_down:
tensorly/decomposition/tests/test_cp.py 100.00% <ø> (ø)
...sorly/decomposition/tests/test_tt_decomposition.py 100.00% <ø> (ø)
tensorly/tenalg/core_tenalg/n_mode_product.py 97.50% <100.00%> (ø)
tensorly/tenalg/tests/test_outer_product.py 100.00% <ø> (ø)
... and 2 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

JeanKossaifi commented 5 months ago

Shall we merge this @aarmey ?

aarmey commented 5 months ago

@JeanKossaifi I'm fine with merging, unless you think we should issue a new version with the deprecation warning that currently exists on main?

aarmey commented 4 months ago

Actually, I think this is important to merge now. It looks like the mxnet repository has been fully archived. The changes here to remove mxnet from the documentation will avoid confusion in the future. Merging.

JeanKossaifi commented 4 months ago

Thanks @aarmey !

JeanKossaifi commented 4 months ago

Should we also start removing TensorFlow @aarmey ?

aarmey commented 4 months ago

I don't think anything has changed since the #490 discussion? TF is at least not outright broken, so there's no rush for deprecating it. On the other hand, if it isn't being used, simplifying the codebase only helps.

bakhtos commented 4 months ago

Hello,

The website of tensorly still promises MxNet.

Screenshot 2024-01-31 at 13 43 20
JeanKossaifi commented 2 months ago

Thanks @bakhtos - we'll update the doc! Feel free to open a small PR if you are able to! :) I opened an issue to track.