tensorly / tensorly

TensorLy: Tensor Learning in Python.
http://tensorly.org
Other
1.51k stars 281 forks source link

moving solvers related code to solvers/* directory, improving fista and nnls_hals #550

Open cohenjer opened 1 month ago

cohenjer commented 1 month ago

This is a copy of the part of #542 related to solvers.

What this PR solves:

What this PR does:

(I left the old proximal file with the modified nnls_hals and fista solvers to show the changes, we can remove it before merging.)

Possible improvements:

Note: If this PR is merged, I will proceed with the nonnegative algorithms improvements in #542.

cohenjer commented 1 month ago

Not sure why the pytorch test for constrained_parafac is returning an error, I did not change the contents of the code there... seems to be a type mismatch between floats and integers but I have no idea why it happens.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 74.66468% with 170 lines in your changes are missing coverage. Please review.

Project coverage is 80.10%. Comparing base (63fc5c5) to head (4386510). Report is 6 commits behind head on main.

:exclamation: Current head 4386510 differs from pull request most recent head c553d69. Consider uploading reports for the commit c553d69 to get more accurate results

Files Patch % Lines
tensorly/solvers/proximal.py 67.50% 91 Missing :warning:
tensorly/solvers/nnls.py 65.07% 44 Missing :warning:
tensorly/tenalg/proximal.py 0.00% 29 Missing :warning:
tensorly/solvers/penalizations.py 92.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #550 +/- ## ========================================== - Coverage 87.30% 80.10% -7.20% ========================================== Files 125 132 +7 Lines 7868 8425 +557 ========================================== - Hits 6869 6749 -120 - Misses 999 1676 +677 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.