search

tensorly / torch

TensorLy-Torch: Deep Tensor Learning with TensorLy and PyTorch
http://tensorly.org/torch/
BSD 3-Clause "New" or "Revised" License
70 stars 18 forks source link

Documentation update? #18

Closed ziyulu-uw closed 2 years ago

ziyulu-uw commented 2 years ago

Hi! I was trying to use the tltorch.factorized_layers.FactorizedLinear, but it seems like the parameters listed on the documentation page http://tensorly.org/torch/dev/modules/generated/tltorch.factorized_layers.FactorizedLinear.html#tltorch.factorized_layers.FactorizedLinear are different from the parameters the model actually takes in now, and I'm not sure how the old parameters are mapped to the new parameter. In particular, I wonder how we can specify the shape of the tensor with the current model parameters in_tensorized_features and out_tensorized_features, and it would be great if you could update the documentation to match the current definition of the model. Thank you very much!

JeanKossaifi commented 2 years ago

Thanks, I've pushed an update. Let me know if anything is unclear.