search

tensorly / viz

Easy visualization and evaluation of matrix and tensor factorization models
https://tensorly.org/viz/
MIT License
16 stars 4 forks source link

a little problem #18

Closed HHhyJJ closed 1 year ago

HHhyJJ commented 1 year ago

When I used the function tlviz.visualisation.core_elementplot to show some results, I found that np.bool is used on line 651 of visualisation.py, which has been deprecated since NumPy 1.20.0, and that made an error in my program. It's successfully run after I changed np.bool to np.bool or bool. There may be other similar errors and I hope it can be fixed.

yngvem commented 1 year ago

Thank you for letting us know @HHhyJJ! I think I fixed it in the issue_18 branch, but I'm having some issue with one of the doctests failing due to a numpy upgrade. Once I've found a solution to these tests, I'll merge the fix into main.

yngvem commented 1 year ago

Should be fixed now, thanks again @HHhyJJ!

HHhyJJ commented 1 year ago

Thank you very much, the tensorly-viz help me a lot and thanks your work!