search

tensortrade-org / tensortrade

An open source reinforcement learning framework for training, evaluating, and deploying robust trading agents.
https://discord.gg/ZZ7BGWh
Apache License 2.0
4.52k stars 1.02k forks source link

Rewrote Docker install, added more than 400 features, BTCUSD dataset split, Optuna, ASHA scheduler, PPO-LSTM, PPO-AttentionNet, DQN-ChronoNet... #381

Closed abstractguy closed 2 years ago

abstractguy commented 2 years ago

This fixes and completes the partial Docker install, which should be preferred over other methods.

abstractguy commented 2 years ago

Alright guys fixed this Travis CI thingy, so ready to be merged!

carlogrisetti commented 2 years ago

Just reporting here what we already discussed on discord: not ready to be merged as per the implied requirements that have been modified also for non-docker users. I'll try to find a common ground between the two deployment options, starting from this PR.

abstractguy commented 2 years ago

Just reporting here what we already discussed on discord: not ready to be merged as per the implied requirements that have been modified also for non-docker users. I'll try to find a common ground between the two deployment options, starting from this PR.

I don't see a difference between the docker install and the pip install -r examples/requirements.txt besides one apt-get install for glx compatibility that was required in the Dockerfile.

carlogrisetti commented 2 years ago

Wow... those are so many changes in a single PR... will be hard to review haha :) In the future try to split them in multiple PRs if you can, so that they can be tested and then merged individually.

I'll try to look into this asap, but I've had some issues delaying this

abstractguy commented 2 years ago

Wow... those are so many changes in a single PR... will be hard to review haha :) In the future try to split them in multiple PRs if you can, so that they can be tested and then merged individually.

I'll try to look into this asap, but I've had some issues delaying this

Yeah. My first PR was concise but I kept developing. Most of the development is in 2 notebooks. I'd review the rest before as 1 update, then check the notebooks.