search

tensortrade-org / tensortrade

An open source reinforcement learning framework for training, evaluating, and deploying robust trading agents.
https://discord.gg/ZZ7BGWh
Apache License 2.0
4.52k stars 1.02k forks source link

Centralized jupyterlab, ipykernel, ipywidgets requirements. #421

Closed abstractguy closed 2 years ago

carlogrisetti commented 2 years ago

Jupyterlab should not be included in the base requirements.txt as it is not needed to run tensortrade. What's the rationale behind adding it also there? Thanks!

Leaving to @rhamnett to the examples requirements, since I'm not a notebook-guy anyways :)

abstractguy commented 2 years ago

Jupyterlab should not be included in the base requirements.txt as it is not needed to run tensortrade. What's the rationale behind adding it also there? Thanks!

Leaving to @rhamnett to the examples requirements, since I'm not a notebook-guy anyways :)

ipykernel is required in docs, jupyterlab is required in examples/requirements.txt and ipython is required in the base requirements. For the setup.py, it's different. It just looks inconsistent to me