search

tensortrade-org / tensortrade

An open source reinforcement learning framework for training, evaluating, and deploying robust trading agents.
https://discord.gg/ZZ7BGWh
Apache License 2.0
4.45k stars 1.01k forks source link

Centralized ccxt requirement. #423

Closed abstractguy closed 2 years ago

carlogrisetti commented 2 years ago

What's the rationale for porting ccxt "back" into the main requirements.txt? It shouldn't be needed at that level for the project to work properly, isn't it? I feel it already is a dependency of something else, but it might be just my custom environment I'm getting confused about.

abstractguy commented 2 years ago

What's the rationale for porting ccxt "back" into the main requirements.txt? It shouldn't be needed at that level for the project to work properly, isn't it? I feel it already is a dependency of something else, but it might be just my custom environment I'm getting confused about.

If ccxt shouldn't be in the base requirements, what's stochastic doing there? Since they're both included in the code, (ccxt in tensortrade/data/cdd.py and stochastic in tensortrade/stochastic/), I thought they could be in the base requirements. Either way, both should be together.