hhsecond commented 4 years ago

Motivation and Context

A continuation from #62 and should also solve #79

Description

[ ] DataAccessor class that acts as a lightweight reader
[x] Native Dataset
[x] Torch Dataset
[x] Tensorflow Dataset
[ ] Support for TF2.0 & TF1.0
[x] Make batching possible for native
[ ] Return namedtuple if find useful
[x] Make shuffling possible (relevant for native and TensorFlow)
[ ] Parallel reads (relevent for native and tensorflow)
[ ] Rebalancing
[ ] Dataset split for the test, train and validation
[ ] Batching nested arrays

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Documentation update
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Is this PR ready for review, or a work in progress?

[ ] Ready for review
[x] Work in progress

How Has This Been Tested?

Put an x in the boxes that apply:

[ ] Current tests cover modifications made
[ ] New tests have been added to the test suite
[ ] Modifications were made to existing tests to support these changes
[ ] Tests may be needed, but they are not included when the PR was proposed
[ ] I don't know. Help!

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have signed (or will sign when prompted) the tensorwork CLA.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

codecov[bot] commented 4 years ago

Codecov Report

Merging #187 into master will decrease coverage by 0.33%. The diff coverage is 86.86%.

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   95.44%   95.12%   -0.33%     
==========================================
  Files          95       98       +3     
  Lines       15622    15584      -38     
  Branches     1487     1484       -3     
==========================================
- Hits        14910    14823      -87     
- Misses        469      510      +41     
- Partials      243      251       +8

Impacted Files	Coverage Δ
src/hangar/remote/server.py	`73.76% <0.00%> (ø)`
src/hangar/repository.py	`95.48% <ø> (ø)`
src/hangar/utils.py	`97.39% <ø> (+2.33%)`	:arrow_up:
src/hangar/_version.py	`96.43% <36.36%> (-3.57%)`	:arrow_down:
src/hangar/dataset/tensorflow_dset.py	`65.71% <65.71%> (ø)`
src/hangar/dataset/numpy_dset.py	`67.57% <67.57%> (ø)`
src/hangar/dataset/__init__.py	`68.75% <68.75%> (ø)`
src/hangar/dataset/common.py	`69.39% <69.39%> (ø)`
src/hangar/dataset/torch_dset.py	`85.19% <85.19%> (ø)`
src/hangar/columns/layout_flat.py	`95.47% <90.00%> (+0.10%)`	:arrow_up:
... and 16 more

CLAassistant commented 4 years ago

All committers have signed the CLA.