tensorwerk / stockroom

Version control for software 2.0
https://tensorwerk.com
Apache License 2.0
64 stars 5 forks source link

Hangar column API #12

Closed hhsecond closed 4 years ago

hhsecond commented 4 years ago

Description

Hangar 0.5 is introducing a backward-incompatible column API and replacing arrayset API. This PR includes necessary changes to make it work with hangar 0.5. It also, makes hangar 0.5 as the minimum version that stockroom could work with

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

rlizzo commented 4 years ago

Hey @hhsecond do you need a review here?

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

lgtm-com[bot] commented 4 years ago

This pull request introduces 2 alerts when merging 6b659118297394e5d00306747bf99594e2456733 into d1335773e33493df07cc95f9bb48fbc351313dd6 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 4 years ago

This pull request introduces 2 alerts when merging caddfc902d05047f35f355e56777e07901178c02 into d1335773e33493df07cc95f9bb48fbc351313dd6 - view on LGTM.com

new alerts:

codecov-commenter commented 4 years ago

Codecov Report

Merging #12 into master will increase coverage by 1.07%. The diff coverage is 91.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   90.94%   92.01%   +1.07%     
==========================================
  Files          15       18       +3     
  Lines         574      551      -23     
  Branches       42       40       -2     
==========================================
- Hits          522      507      -15     
+ Misses         41       33       -8     
  Partials       11       11              
Impacted Files Coverage Δ
stockroom/storages/data.py 77.77% <66.66%> (-22.23%) :arrow_down:
stockroom/core.py 76.78% <76.78%> (ø)
stockroom/storages/experiment.py 81.81% <81.81%> (ø)
stockroom/storages/model.py 81.81% <83.05%> (-6.42%) :arrow_down:
stockroom/keeper.py 91.66% <91.66%> (ø)
stockroom/__init__.py 100.00% <100.00%> (ø)
stockroom/cli.py 88.88% <100.00%> (+88.88%) :arrow_up:
stockroom/parser.py 100.00% <100.00%> (ø)
stockroom/storages/__init__.py 100.00% <100.00%> (ø)
tests/conftest.py 100.00% <100.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d133577...b2b4033. Read the comment docs.

hhsecond commented 4 years ago

Closing in favor of #16