jjmachan commented 4 years ago

Description

Why is this change required? What problem does it solve? Describe your changes in detail:

Adding

ImageFolder
Pascal VOC (both segmentation and detection)
COCO (both captions and detection

I have changed the default download directory from home to cwd. And modified the cli import functionalities to include addition of str columns and subsamples attribute.

If dtypes returns a datatype that is a list then it is assumed to contain subsamples. This is a conversion I assumed for now. your thoughts?

If it fixes an open issue, please link to the issue here:

Screenshots (if appropriate):

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Documentation update
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

codecov-commenter commented 4 years ago

Codecov Report

Merging #34 into master will increase coverage by 0.08%. The diff coverage is 91.96%.

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   91.96%   92.04%   +0.08%     
==========================================
  Files          21       23       +2     
  Lines         759     1069     +310     
  Branches       55       88      +33     
==========================================
+ Hits          698      984     +286     
- Misses         47       64      +17     
- Partials       14       21       +7

Impacted Files	Coverage Δ
tests/test_cli.py	`100.00% <ø> (ø)`
stockroom/external/importer/utils.py	`44.18% <25.92%> (-30.82%)`	:arrow_down:
...ockroom/external/importer/torchvision_importers.py	`95.95% <95.30%> (+9.51%)`	:arrow_up:
tests/importer/test_torchvision.py	`98.52% <98.52%> (ø)`
stockroom/cli.py	`85.36% <100.00%> (+1.36%)`	:arrow_up:
tests/importer/conftest.py	`100.00% <100.00%> (ø)`
tests/importer/torchvision_datasets.py	`100.00% <100.00%> (ø)`
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dc9a983...f777f46. Read the comment docs.

hhsecond commented 4 years ago

Rejecting it to split the PR into multiple smaller ones

tensorwerk / stockroom

importer: added ImageFolder, VOC and COCO #34