Code review

[tensory]

Please review version with More Results button. /cc @nesquena @tim1ee

[nesquena]

:+1: Hey Ari, project looks good, nice work. A few points of feedback:

• Proper layout and view naming, uses relative layouts, string resources, etc
• Properly reused the same method doSearch for both initial load and the pagination (and tracked index)
• "Load More" button on the view and hooked up with paginating (although it clears the previous results when I load more, such that I lose older results with no way to get back)
• (Minor UI) Might consider in the future using a progress bar (or simple toast) and displaying it when the "Load More" is clicked (as a progress indicator)
• Properly used spinners (with populated values) to allow users to select filters
• Properly send and receive relevant filters using a bundle to pass data between activities
• One odd UX is that when I re-enter advanced settings, none of the filters I selected stick (not re-selected)

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be very important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

[tensory]

Now that I read your comments, a "Load More" UI makes more sense in practice. As you can see, I naively treated "More Results" as a straight replacement action... when of course it would make more sense to have just appended a new batch of list items! Thanks for the feedback.

I will keep in mind the thoughts about persisting settings states for the Twitter app. I also want to work out how to allow blank and deactivated settings.

Thanks again.

On Thu, Sep 5, 2013 at 12:19 PM, Nathan Esquenazi notifications@github.comwrote:

[image: :+1:] Hey Ari, project looks good, nice work. A few points of feedback:

• Proper layout and view naming, uses relative layouts, string resources, etc
• Properly reused the same method doSearch for both initial load and the pagination (and tracked index)
• "Load More" button on the view and hooked up with paginating (although it clears the previous results when I load more, such that I lose older results with no way to get back)
  • (Minor UI) Might consider in the future using a progress bar (or simple toast) and displaying it when the "Load More" is clicked (as a progress indicator)
  • Properly used spinners (with populated values) to allow users to select filters
• Properly send and receive relevant filters using a bundle to pass data between activities
• One odd UX is that when I re-enter advanced settings, none of the filters I selected stick (not re-selected)

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be very important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

— Reply to this email directly or view it on GitHubhttps://github.com/tensory/GImageSearch/issues/1#issuecomment-23894287 .