Please code review for Homework 4

[tensory]

Hi! Here's my Homework 4.

Now that I know about using fragments, I would like to manage activities through nested fragments instead of popping new activities. Two things happen that I would like to redesign this app to fix:

• LoginActivity runs in the background as soon as the focus switches to TimelineActivity (so it is visible when the user hits "back" to get out of the app)
• Every click on a profile icon pops a new ProfileActivity instance and I think it would be better if new visits to a profile fitted into one reusable ProfileActivity. Would welcome UX thoughts.

Thanks for all the help on Monday!

/cc @nesquena @timothy1ee

[nesquena]

:+1: Great work Ari, few points of feedback:

• Used FrameLayout to act as a container for timeline tab content
• Setup ActionBar Tabs mode with the Home and Mentions timeline tabs
  • Should checkout tabs cliffnotes to see how you might do this in a Gingerbread compatible way and using a "FragmentTabListener" which is recommended approach by Google.
• Setup the base fragment class that the timelines all extend from
  • Can remove unnecessary TimelineJsonHttpResponseHandler which is unused
• Setup home timeline fragment without much unnecessary code duplication
• Setup mentions timeline fragment without much unnecessary code duplication
• NOTE: There's quite a bit of cleanup we could do in HomeTimeline, Mentions, and UserTimeline to remove even more duplication
  • For example, setup an abstract method called "populateTimeline" and then have the endless scroll listener and onCreate just invoke that method
  • Then the individual timelines extending from the base would just implement that one method and everything else could be pushed to base
  • Happy to help you refactor this if you are curious and the above description isn't clear enough
• Setup endless pagination that works across home and mention timelines
• Setup user profile view with profile header and a user timeline fragment
  • Can view my profile by clicking on the ActionBar
  • MISSING: Profile timeline shows wrong tweets (from home timeline), should show user's tweets
• Clicking on a users profile image takes me to their profile
  • Nice use of ProfileImageOnClickListener to manage the user clicking handler
  • BUG: same as above, doesn't actually display profile tweets (just shows hometimeline)
• Compose works and refreshes the home timeline properly

Nice work overall, hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for instagram, pinterest, yardsale, flickr, .

Today (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 we will be covering all the topics that separate an intermediate Android developer from a beginner that will act things you should start reviewing to continue your path to being a great Android developer.

Week 7 (Sept 30th), we are going to have a demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group apps that you all have built. We are going to help however we can over the next 2 weeks to get the apps in shape and also have you all prepare a short slide presentation as well.