tenstorrent / tt-buda-demos

Repository of model demos using TT-Buda
Other
47 stars 14 forks source link

Add device_config to test option for customer models #96

Closed ashokkumarkannan1 closed 1 month ago

nvukobratTT commented 1 month ago

@milank94 would like to hear your opinion on including test_device within the test name.

For proper CI testing and easier device type specification (e.g. n150, n300, e150, e300, etc) we need to make these kinds of changes. Have in mind that this is mostly for Golden running and testing purposes.

Let me know if this is problematic for the tt-buda-demos side. If yes, going forward we can discuss the potential discard of Golden tracking/testing on our end, and only focus on silicon runs for this model demos.

Before making any conclusions, let me know your thoughts.

milank94 commented 1 month ago

@milank94 would like to hear your opinion on including test_device within the test name.

For proper CI testing and easier device type specification (e.g. n150, n300, e150, e300, etc) we need to make these kinds of changes. Have in mind that this is mostly for Golden running and testing purposes.

Let me know if this is problematic for the tt-buda-demos side. If yes, going forward we can discuss the potential discard of Golden tracking/testing on our end, and only focus on silicon runs for this model demos.

Before making any conclusions, let me know your thoughts.

Thanks @nvukobratTT. My thoughts on this:

nvukobratTT commented 1 month ago

Thanks for your thoughts @milank94! Yes,

If it works for you, let's merge these changes into tracking branch, and you can have a more detailed overview before we officially merge those into the main branch.

milank94 commented 1 month ago

Thanks for your thoughts @milank94! Yes,

  • These changes are related only to tests/ directory and are purely impacting our testing infrastructure.
  • There shouldn't be any "hidden" changes that will impact model demos. Customers should have unchanged interface and behavior of their models

If it works for you, let's merge these changes into tracking branch, and you can have a more detailed overview before we officially merge those into the main branch.

Sounds great. Thanks @nvukobratTT