search

tenstorrent / tt-flash

Tenstorrent Firmware Update Utility
Apache License 2.0
11 stars 6 forks source link

Missing --fw-tar option from --help menu. #9

Open hmohiuddinTT opened 8 months ago

hmohiuddinTT commented 8 months ago

Missing the --fw-tar option from the --help menu.

image

Related to: https://github.com/tenstorrent/tt-flash/blob/9808227dc84ec5e0d5a81d8860b04f9e31338159/tt_flash/main.py#L70C1-L71C1

warthog9 commented 7 months ago

That's odd it looks like it should be there already:

https://github.com/tenstorrent/tt-flash/blame/bd53bc043189baa8324b8ffbb9454ee3650c54b6/tt_flash/main.py#L70

When you get a chance can you re-test with latest?

warthog9 commented 7 months ago

(venv) root@orko:~# tt-flash --help usage: tt-flash [-h] [-v] [--force] [--fw-tar FW_TAR]

options: -h, --help show this help message and exit -v, --version show program's version number and exit --force Force update the ROM --fw-tar FW_TAR Path to the firmware tarball (venv) root@orko:~#

I think this is already resolved so going to close this

warthog9 commented 7 months ago

Ok re-opening as I figured out what's going on, and this is valid. The help text EXISTS, except when you run the top level tt-flash --help or tt-flash without anything it shows the options for tt-flash but DOES NOT show that the commands exist. So we need a way to get what commands are available into the top level help more obviously

afaerber commented 2 months ago

As visible at the bottom of the first screenshot, it does show the commands:

command:
  {flash}

What's missing is a sentence to the effect of, "See tt-flash {command} --help for further command-specific help."