search

tenstorrent / tt-llk-bh

Tenstorrent low-level tensix kernels for Blackhole
Apache License 2.0
3 stars 0 forks source link

fix for pack reconfig for uint8 #30

Closed rdjogoTT closed 1 month ago

rdjogoTT commented 1 month ago

On packer reconfig, PCK_DEST_RD_CTRL_Read_unsigned would not get updated in the case of switching to packing uint8 data, resulting in it being packed out as int8 instead (packed MSB would be taken as sign bit of container rather than the 8th LSB).

ttmtrajkovic commented 1 month ago

looks good. is this setting covered if there's no reconfig and there's only one output CB with uint8?

rdjogoTT commented 1 month ago

is this setting covered if there's no

If you mean if the initial config is done for uint8 then yes, this setting is covered in the set_packer_config that gets called. I added that a few weeks back when I enabled uint8 math.

ttmtrajkovic commented 1 month ago

is this setting covered if there's no

If you mean if the initial config is done for uint8 then yes, this setting is covered in the set_packer_config that gets called. I added that a few weeks back when I enabled uint8 math.

yeah, that's what I meant - thanks.