search

tenstorrent / tt-metal

:metal: TT-NN operator library, and TT-Metalium low level kernel programming model.
Apache License 2.0
381 stars 47 forks source link

[Blackhole Bringup] New SFPU functions #10226

Closed rtawfik01 closed 2 days ago

rtawfik01 commented 1 month ago

New SFPU functions are missing for BH like (softplus, remainder, bitwise ops, etc)

@abhullar-tt fyi

rtawfik01 commented 1 month ago

Copied the SFPU files from WHB0 to BH in this PR: #10233

Using this test to clear this PR:

pytest -svv tests/tt_eager/python_api_testing/sweep_tests/pytests/tt_dnn/test_eltwise_unary.py

A few new ops have been added to wormhole_b0 in the meantime, like ckernel_sfpu_ceil.h. This will need to be ported over as well

A few ops also mismatch in the above test suite.

@ttmtrajkovic fyi

rdjogoTT commented 1 month ago

I have looked through the ckernel_sfpu_....h files in the tt_metal/hw/ckernels/blackhole/metal/llk_api/llk_sfpu/ directory and compared to the WHB0 directory, and the differences that still remain are the following:

ncvetkovicTT commented 2 weeks ago

I have looked through the ckernel_sfpu_....h files in the tt_metal/hw/ckernels/blackhole/metal/llk_api/llk_sfpu/ directory and compared to the WHB0 directory, and the differences that still remain are the following:

  • [ ] trunc OP works but the stack has it disabled for all arches except whb0 - update to also include BH
  • [ ] calculate_int_mask() missing in ckernel_sfpu_mask.h
  • [ ] ckernel_sfpu_recip.h differ - WHB0 calls on the submodule to calculate
  • [ ] ckernel_sfpu_sqrt.h differ - WHB0 calls on the submodule to calculate
  • [ ] ckernel_sfpu_reshuffle_rows.h missing - was never added to BH

@rdjogoTT Whenever you can, take a look at #11816

ncvetkovicTT commented 2 days ago

ckernel_sfpu_reshuffle_rows.h will be addressed in #11816.