tenstorrent / tt-metal

:metal: TT-NN operator library, and TT-Metalium low level kernel programming model.
Apache License 2.0
466 stars 73 forks source link

Override runutime args are not matching the non override runtimeargs #10524

Open ygiladTT opened 3 months ago

ygiladTT commented 3 months ago

The override lambda function in the file op_library/concat/multi_core/concat_op_multi_core.cpp function : s2s_rm_concat_multi_core are not matching the actual runtime argument setting earlier in the function , meaning that when there is a cache hit on the op, it is not going to update the runtime arguments correctly. please make sure to update the override function of this function and potentially test cache hit cases so that such issues could be captured

tt-aho commented 3 months ago

@tarafdarTT I think you made changes to this fn/args a while back, and looks like the override wasn't updated

ntarafdar commented 2 months ago

@jaykru-tt could you look at this. It's a matter of modifying the override runtime args to make sure it matches the normal one.