tenstorrent / tt-metal

:metal: TT-NN operator library, and TT-Metalium low level kernel programming model.
Apache License 2.0
388 stars 47 forks source link

Add `git_branch_name` and `github_job_run_link` to `environment.csv` for benchmarks #10680

Closed tt-rkim closed 2 weeks ago

tt-rkim commented 1 month ago

Requested by @skhorasganiTT

tt-rkim commented 1 month ago

@FrancesssZ @skhorasganiTT We have difficulty getting github_job_id within the actual GitHub running job. It sucks. I can explain more if you'd like.

Because of this, @skhorasganiTT are you ok if we just link to the workflow (whole pipeline)? Rather than the specific job? I propose we change github_job_run_link to github_pipeline_run_link.

skhorasganiTT commented 1 month ago

Discussed this with @tt-rkim , the pipeline link is sufficient for our request.

FrancesssZ commented 1 month ago

@tt-rkim @skhorasganiTT I'll name it as github_pipeline_link to align with another column that we already have in the env file called github_pipeline_id. Please let me know if you're both good with this.

tt-rkim commented 1 month ago

We're both good

FrancesssZ commented 1 month ago

Changes on data team have been deployed @tt-rkim @skhorasganiTT

uaydonat commented 3 weeks ago

@tt-rkim this issue is a blocker for us for to be able to use the dashboard in our daily analysis. Do you have an ETA? If not soon, then we can take a look?

tt-rkim commented 3 weeks ago

@skhorasganiTT , for these two fields, edit function infra/data_collection/github/utils.py:create_csv_for_github_benchmark_environment:

skhorasganiTT commented 3 weeks ago

Thanks @tt-rkim

tt-rkim commented 2 weeks ago

@skhorasganiTT pls close if done