Open aliuTT opened 2 months ago
Will this be back-propagated to all instances where the flag is used?
Or is it up to each model owner to check their model and update it?
I updated it for all the Metal CPP tests and a few fixtures, but I saw a lot of model/op specific tests that had this flag. I didn't feel confident modifying all of them, so leaving it to model owner to check their own tests.
Ping on this, any plans to get WH_ARCH_YAML
removed from tests?
@aliuTTYes, but low priority at the moment.
WH_ARCH_YAML is removed from runtime backend,
CreateDevices
andCreateDevice
now asks for dispatch_core_type. So we will need model writers to update tests and conftest. Today, I added this logic so CI is clean:We can go with either a new fixture, maybe
eth_dispatch_fixture
or passdispatch_core_type
intodevice_params
for the currentdevice
fixture. I have no preference either way. Once tests are updated to use either method, we can removeWH_ARCH_YAML
from all test scripts.Linking commit from main: https://github.com/tenstorrent/tt-metal/commit/509b2159ac3af3f6ad2301294a45df5bf1ce7d46