Blackhole CNN bringup - Githubissues

abhullar-tt commented 1 month ago

This issue is meant to act as master list for ops we need to enable CNNs on BH

@mywoodstock helped put together a list Resnet ops/ ops to prioritize for CNNs:

[ ] BinaryDeviceOperation
[ ] InterleavedToSharded
[ ] Matmul
[ ] Move
[ ] PadOnHost
[ ] Reduce
[ ] Reshard
[ ] Tilize
[ ] TilizeWithValPadding
[ ] Untilize
[ ] UntilizeWithUnpadding
[ ] Halo: This is run as part of below two ops (incl. in their unit tests.)
[ ] MaxPoolNew: pytest tests/ttnn/unit_tests/operations/test_maxpool2d.py
[ ] OptimizedConvNew: pytest tests/ttnn/unit_tests/operations/test_new_conv2d.py

I believe all these ops should have relevant pytests

FYI @rtawfik01 @davorchap @jvasilje

rtawfik01 commented 1 month ago

@mywoodstock is it also possible to add a test to run for each of the above?

pgkeller commented 1 month ago

marking P0 as this gates BH checkout

pgkeller commented 1 month ago

Assigned Abhinav. See also these 2 issues for llk work:

[] #10498
[] #10052

rtawfik01 commented 2 weeks ago

Hi I closed #10498, which enables a lot of maxpool/conv tests to run now, but now we need a list of the unit tests for each of the above ops, and update them. I have tried running some different unit tests and some need BH updates: https://github.com/tenstorrent/tt-metal/issues/11684

mywoodstock commented 2 weeks ago

I updated the description with the unit tests for the CNN specific ops (maxpool, conv, halo.) Will take a look at #11684

tenstorrent / tt-metal

Blackhole CNN bringup #11124