tenstorrent / tt-metal

:metal: TT-NN operator library, and TT-Metalium low level kernel programming model.
Apache License 2.0
415 stars 53 forks source link

Pack Untilize gives bad PCC when block_ct_dim < full_ct_dim #11573

Open yugaoTT opened 1 month ago

yugaoTT commented 1 month ago

Describe the bug for Conv unit test, block_ct_dim=1, full_ct_dim = 2, pack_untilize gives garbage PCC, when set block_ct_dim= full_ct_dim=2, PCC is good.

To Reproduce Steps to reproduce the behavior:

  1. Go to yugao/pack_untilize
  2. Run pytest tests/ttnn/unit_tests/operations/test_new_conv2d.py::test_unet_conv_wh
  3. To get rid of the PCC error, comment out the hard-coded out_subblock_h_ntiles = 1; out_subblock_w_ntiles = 1; in ttnn/cpp/ttnn/operations/conv/conv2d/conv2d.cpp
yugaoTT commented 1 month ago

fyi @mywoodstock