search

tenstorrent / tt-metal

:metal: TT-NN operator library, and TT-Metalium low level kernel programming model.
Apache License 2.0
415 stars 53 forks source link

Facing shape mismatch issue with conv in MobilenetV2 #12141

Open keerthana-r-mcw opened 3 weeks ago

keerthana-r-mcw commented 3 weeks ago

Describe the bug Facing The width of the first tensor must be equal to the height of the second tensor. with conv in MobilenetV2 unit test cases.

To Reproduce Steps to reproduce the behavior:

  1. Checkout keerthanar/mobilenetv2_unittest_cases
  2. Run pytest tests/ttnn/unit_tests/operations/test_new_conv2d.py::test_conv_mobilenetv2_matmul_issue

Please complete the following environment information:

sankarmanoj-tt commented 2 weeks ago

This bug has been fixed in the smanoj/segformer_bias_fix branch

keerthana-r-mcw commented 2 weeks ago

Hi @sankarmanoj-tt , I checkedout smanoj/segformer_bias_fix branch, and tried running the test. But the error persists.

sankarmanoj-tt commented 2 weeks ago

Did you rebuild after checking out the branch?

keerthana-r-mcw commented 2 weeks ago

Yes, I rebuilt the repo after checking out the branch.

dvartaniansTT commented 1 week ago

@keerthana-r-mcw doesn't look like this issue is resolved! why is it closed?

sankarmanoj-tt commented 5 days ago

@keerthana-r-mcw Please checkout this branch and try. smanoj/fix_matmul_validation

keerthana-r-mcw commented 5 days ago

Hi @sankarmanoj-tt , The test is working with this branch. Thanks!

bbradelTT commented 5 days ago

@keerthana-r-mcw @sankarmanoj-tt the error message is there for a reason. There are corner cases where the output may be incorrect if the assertion is not satisfied.

You need to change the model or underlying conv code to make the shapes line up.