search

tenstorrent / tt-metal

:metal: TT-NN operator library, and TT-Metalium low level kernel programming model.
Apache License 2.0
471 stars 73 forks source link

Add Row Major support for TTNN Embedding #13593

Open yugi957 opened 1 month ago

yugi957 commented 1 month ago

Describe the bug Even after fixing Reshape RM issue, it seems embedding is still not seeing the tensor as RM: TT_FATAL @ ../ttnn/cpp/ttnn/operations/embedding/device/embedding_device_operation.cpp:25: a.get_layout() == Layout::ROW_MAJOR

Ex input: {'weight_shape': [81, 768], 'indices_shape': [1, 24], 'padding_idx': 1}

To Reproduce Can filter the cloud kibana by data_movement.embbedding.embedding_pytorch2 or run the gh workflow accordingly

Expected behavior Should either convert to RM or support tilized

jaykru-tt commented 1 month ago

Can you clarify what you mean by "embedding is still not seeing the tensor as RM"? Pasting the exception itself would be good.