clean up tt_memory span packing

tenstorrent / tt-metal

:metal: TT-NN operator library, and TT-Metalium low level kernel programming model.

https://docs.tenstorrent.com/ttnn/latest/index.html

Apache License 2.0

484 stars 80 forks source link

clean up tt_memory span packing #13944

Open pgkeller opened 1 month ago

pgkeller commented 1 month ago

Presently spans are packed by looking at the firmware base addresses from dev_mem_map.h to determine if a span is in the text or data section. The new elf loader natively understands text/data sections so we can use this info to avoid this ugly inference pattern.

blozano-tt commented 6 days ago

@pgkeller @nathan-TT @jbaumanTT is this still true?

I don't notice any usage of dev_mem_map.h in tt_memory.cpp or tt_memory.hpp

I see an include of tensix.h but I think that is dead code.

Maybe we can close this?

nathan-TT commented 6 days ago

I have not started investigating

pgkeller commented 6 days ago

no, can't close. a recent change put that code behind the hal, but it needs to be deleted in favor of a better methodology (no need to depend on the dev mem map at all)