search

tenstorrent / tt-metal

:metal: TT-NN operator library, and TT-Metalium low level kernel programming model.
Apache License 2.0
463 stars 72 forks source link

ttnn.tan low PCC #14086

Open dveizovicTT opened 2 weeks ago

dveizovicTT commented 2 weeks ago

Describe the bug ttnn.tan has low PCC for some inputs. For all failures PCC is around 0.993

To Reproduce Steps to reproduce the behavior: Checkout branch: dveizovic/sweeps-migration Sweep test for tan is located in 'tests/sweep_framework/sweeps/eltwise/unary/tan/tan.py'

  1. Go to 'tests/sweep_framework/sweeps/eltwise/unary_backward/rdiv_bw/rdiv_bw.py'
  2. Generate new parameter vectors and run the sweep test 
    python3 tests/sweep_framework/parameter_generator.py --elastic cloud --module-name eltwise.unary.tan.tan
python3 tests/sweep_framework/runner.py --elastic cloud --module-name eltwise.unary.tan.tan --suite-name nightly
  3. See the error. Results can be found on elastic cloud as explained here: https://github.com/tenstorrent/tt-metal/tree/main/tests/sweep_framework
eyonland commented 3 days ago

I'm not finding the tests you mentioned above. Are they on a different branch?