tenstorrent / tt-metal

:metal: TT-NN operator library, and TT-Metalium low level kernel programming model.
Apache License 2.0
462 stars 70 forks source link

ttnn.angle_bw binary inconsistent documentation regarding the input tensors datatype #14145

Closed amalbasaTT closed 22 hours ago

amalbasaTT commented 1 week ago

ttnn.angle_bw doesn't support bfloat8_b on input_tensor_a. Fatal error "Unsupported DataType" is thrown when input_tensor_a has bfloat8_b.

To Reproduce Steps to reproduce the behavior: Sweep test for angle_bw is located in 'tests/sweep_framework/sweeps/eltwise/unary_complex/angle_bw/angle_bw.py'

  1. Checkout main branch
  2. Go to 'tests/sweep_framework/sweeps/eltwise/unary_complex/angle_bw/angle_bw.py'
  3. Remove next lines of code from the invalidate_vector function:
    if test_vector["input_a_dtype"] == ttnn.bfloat8_b:
        return True, "bfloat8_b is not supported on input_tensor_a"
  4. Generate new parameter vectors and run the sweep test
    python3 tests/sweep_framework/sweeps_parameter_generator.py --elastic cloud --module-name eltwise.unary_complex.angle_bw.angle_bw
    python3 tests/sweep_framework/sweeps_runner.py --elastic cloud --module-name eltwise.unary_complex.angle_bw.angle_bw 
  5. See error. Results can be found on elastic cloud as explained here: https://github.com/tenstorrent/tt-metal/tree/main/tests/sweep_framework

Expected behavior For vectors with input_a_dtype being bfloat8_b, test will fail with the message "Unsupported DataType".

mouliraj-mcw commented 22 hours ago

closing as completed