search

tenstorrent / tt-metal

:metal: TT-NN operator library, and TT-Metalium low level kernel programming model.
Apache License 2.0
471 stars 74 forks source link

Maxpool support for skipped cases #14292

Open HariniMohan0102 opened 3 weeks ago

HariniMohan0102 commented 3 weeks ago

Describe the bug The input configurations of MaxPool2d op of PETR VovNetCP submodule gets skipped. SKIPPED (kernel size and padding combination not supported)

To Reproduce Steps to reproduce the behavior:

  1. Checkout to the branch: harini/petr_vovnetcp_maxpool
  2. Run the command: pytest tests/ttnn/unit_tests/operations/test_maxpool2d.py::test_petr_vovnetcp

Expected behavior Expected to get ttnn MaxPool2d support for the input configurations.

Please complete the following environment information:

HariniMohan0102 commented 3 weeks ago

Hi @mywoodstock, Is there any workaround for now or any roadmap for supporting these cases?

mywoodstock commented 3 weeks ago

@HariniMohan0102, they should actually now be supported. Could you try with removing those pytest skips in the test function? If any of those cases fail we will take a look.

mywoodstock commented 3 weeks ago

@HariniMohan0102 Actually I tried these cases and there are issues -- we will work on fixing those.

jvasilje commented 2 weeks ago

@mywoodstock is really a P0 issue (as in company wide emergency)?

mywoodstock commented 1 week ago

@HariniMohan0102 Could you please try these tests with the latest main and let me know if some still fail. Thanks!

HariniMohan0102 commented 5 days ago

Hi @mywoodstock, I've tested with latest main. By commenting the skip statements from the function, 2 configurations passed. The other configuration fails in bfloat16 and gets skipped in bfloat8_b. I've updated the unit test branch with the failing case.