tenstorrent / tt-metal

:metal: TT-NN operator library, and TT-Metalium low level kernel programming model.
Apache License 2.0
458 stars 68 forks source link

Semantic change in CreateSemaphore API is not documented #14457

Open csehydrogen opened 3 days ago

csehydrogen commented 3 days ago

In the past, CreateSemaphore directly returned L1 address of the semaphore allocated. Now, CreateSemaphore returns ID (0, 1, 2, ...) and L1 address should be obtained via get_semaphore. This behavior change is not yet reflected into documentation.

tt-aho commented 2 days ago

Hey @csehydrogen, thanks for flagging this. I've updated the relevant comments to reflect what the returned value is/should be used, we are now just waiting on having the published docs regenerated.