tenstorrent / tt-metal

:metal: TT-NN operator library, and TT-Metalium low level kernel programming model.
https://docs.tenstorrent.com/ttnn/latest/index.html
Apache License 2.0
493 stars 82 forks source link

ttnn.reshape with bfloat8_b input on some shapes gives low PCC #14513

Open nemanjagrujic opened 1 month ago

nemanjagrujic commented 1 month ago

ttnn.reshape with bfloat8_b input on some shapes gives low PCC. Interesting is that on some shapes we are getting good pcc. For instance:

input_shape [5, 4, 208, 156] rehape_shape [3, 13, 8, 2080] input_a_dtype DataType.BFLOAT8_B
PCC = -0.0015951839508086992

Checkout main branch.

You can reproduce this error with sweep test tests/sweep_framework/sweeps/data_movement/reshape/reshape.py. To run:

python3 tests/sweep_framework/sweeps_runner.py --elastic cloud --module-name data_movement.reshape.reshape

Results can be found on elastic cloud as explained here: https://github.com/tenstorrent/tt-metal/tree/main/tests/sweep_framework

jvegaTT commented 3 days ago

Issue is resolved in PR https://github.com/tenstorrent/tt-metal/pull/15572, the above test was proven to pass and added to the pytest script