tenstorrent / tt-metal

:metal: TT-NN operator library, and TT-Metalium low level kernel programming model.
Apache License 2.0
478 stars 78 forks source link

#0: Fix grabbing data from ethernet cores #15335

Closed jbaumanTT closed 2 hours ago

jbaumanTT commented 21 hours ago

Problem description

I'm seeing Always | FATAL | Bounds-Error -- Logical_core=(x=9,y=0) is outside of ethernet logical grid in test_pgm_dispatch with TT_METAL_DEVICE_PROFILER_DISPATCH=1 TT_METAL_DEVICE_PROFILER=1`.

What's changed

tt::Cluster::instance().get_soc_desc(device_id).physical_ethernet_cores returns a physical coordinates, so we can remove the conversion from logical to physical.

Checklist

mo-tenstorrent commented 20 hours ago

Good find I missed that on the PR. In the process of fixing eth dispatch profiling, that feature never was fully functional so maybe just run https://github.com/tenstorrent/tt-metal/actions/workflows/run-profiler-regression-wrapper.yaml on it

mo-tenstorrent commented 20 hours ago

Just ran it actually https://github.com/tenstorrent/tt-metal/actions/runs/11961016335