tenstorrent / tt-metal

:metal: TT-NN operator library, and TT-Metalium low level kernel programming model.
Apache License 2.0
377 stars 46 forks source link

Investigate GitHub Actions PR commit checks to enforce blocking on bad commits #1768

Open tt-rkim opened 1 year ago

tt-rkim commented 12 months ago

https://github.com/tenstorrent-metal/tt-metal https://github.com/tenstorrent-metal/metal-workflows https://github.com/tenstorrent-metal/tt-metal/blob/main/.github/workflows/build-and-unit-tests.yaml - post commit workflow docs https://docs.github.com/en/actions/using-workflows/about-workflows https://josh-ops.com/posts/using-github-checks-api/ https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28 Some things to consider: We want commit statuses to be turned to pending before a workflow starts We want commit statuses to be turned to fail/success after a workflow finishes There should be no commit status on the head of a branch if a workflow was not dispatched on that branch We want to reduce duplicate commit status code across multiple workflows and potentially across multiple repositories If you think of any ideas that you think may work better or better designs just let me know

tt-rkim commented 8 months ago

We have decided to go with pull_request trigger for static checks, quick things that can run on GitHub Ubuntu.

We still need something for future silicon-required runs.