search

tenstorrent / tt-metal

:metal: TT-NN operator library, and TT-Metalium low level kernel programming model.
Apache License 2.0
469 stars 73 forks source link

Two version of `test_rw_buffer`, can we remove one #7371

Open vtangTT opened 7 months ago

vtangTT commented 7 months ago

There are two versions of this test: tests/tt_metal/tt_metal/perf_microbenchmark/old/pcie/test_rw_buffer.cpp tests/tt_metal/tt_metal/perf_microbenchmark/3_pcie_transfer/test_rw_buffer.cpp

The first one is using SD and the second FD.

Can we remove one of them?

@tt-rkim

tt-rkim commented 7 months ago

We ideally want to keep the 2nd only , but I think it's not run in regression yet...

If it is, then let's just get rid of the first one. We might need an open issue to integrate it into our benchmarking csv infra

TT-billteng commented 7 months ago

who owns perf_microbenchmark folder?

tt-rkim commented 7 months ago

It's mostly Moreh while I helped them with integrating into the CI and infra. There are a couple of microbenchmarks in there @mo-tenstorrent has touched and previously Andrew G, but it's mostly Moreh.

I believe the current state of the folder is:

There are older benchmarks that Moreh has in there which are currently on CI. They wanted to replace them with new ones, but they 're not on CI yet and need to be hooked up to the CSV reporting infra.