tenstorrent / tt-metal

:metal: TT-NN operator library, and TT-Metalium low level kernel programming model.
Apache License 2.0
420 stars 54 forks source link

Maxpool Config Support Needed for YoloV4 #7746

Closed saichandax closed 3 weeks ago

saichandax commented 5 months ago

Maxpool variant in YoloV4 Neck Sub-Module fails ,

 "act_shape, kernel_size, padding, stride",
    [
        ((1, 512, 10, 10), (5, 5), (2, 2), (1, 1)),  # Pcc drop ~0.74
         ((1, 512, 10, 10), (9, 9), (4, 4), (1, 1)), #hang issue
        ((1, 512, 10, 10), (13, 13), (6, 6), (1, 1)),  # statical buffer issue
    ],

To run the unit test, Use the following steps:

Note: The second configuration is commented in unit test as it hangs. To test it please uncomment the line.

ankitmcw commented 5 months ago

Op report: ops_perf_results_yolov4_maxpool_2024_04_23_08_57_22.csv

punithsekar commented 2 months ago

Currently we face the following issues,

 "act_shape, kernel_size, padding, stride",
    [
        ((1, 512, 10, 10), (5, 5), (2, 2), (1, 1)),  # Pcc drop ~0.74
         ((1, 512, 10, 10), (9, 9), (4, 4), (1, 1)), #hang issue
        ((1, 512, 10, 10), (13, 13), (6, 6), (1, 1)),  # statical buffer issue
    ],

To run the unit test, Use the following steps:

Note: The second configuration is commented in unit test as it hangs. To test it please uncomment the line.

mywoodstock commented 3 weeks ago

this is done.