Open marty1885 opened 2 months ago
Setting as P2 and triaging to the infra queue to comment on the build.
Hi @marty1885, I agree that we should do this and will act in the near future. FYI, we just got full Metal CMake support as of today. Give it a try :)
@TT-billteng Just tried. I love it. Works really well!
Minor note. It'll be great if you could enable precompiled headers during build. Should cut down the build time by a lot for Metalium. TTNN takes a while to build, I think it'll greatly benefit from it.
Minor note. It'll be great if you could enable precompiled headers during build. Should cut down the build time by a lot for Metalium. TTNN takes a while to build, I think it'll greatly benefit from it.
@vtangTT
Hi @marty1885, thank you for your helpful feedback. I agree that precompiled headers are something we should be using more in the future. I've added some in this PR: https://github.com/tenstorrent/tt-metal/pull/8265 mainly for our third party headers such as pybinds, and that should help a little bit.
Unfortunately, right now it seems metal doesn't play well with pch due to the different build flags of our targets and rapidly changing header files. Please let me know if you see any other areas for improvement!
Is your feature request related to a problem? Please describe.
Most (at least a large chunk of) C++ code base uses CMake as the build system (generator). So far my projects uses my own script to hack to let programs see Metalium. It'll be nice to be able to have some
MetaliumConfig.cmake
that the project comes with, which also makes outside projects immune to Metalium structure and dependency changes.Describe the solution you'd like
A
MetaliumConfig.cmake
that gets included in the tt-metal repository. Which I can use to link against Metalium like so:Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.
Additional context Add any other context or screenshots about the feature request here.