But these actually need to come from the metal device i.e. device->get_l1_alignment(), so that we don't have hard coded architecture specific numbers in our runtime. If these APIs don't exist in metal, let's file an issue and get signoff from the metal team, should be relatively uncontroversial. Please tag any filed issues against metal on this issue.
Currently we are using defines
L1_ALIGNMENT
,PCIE_ALIGNMENT
, andDRAM_ALIGNMENT
:But these actually need to come from the metal device i.e.
device->get_l1_alignment()
, so that we don't have hard coded architecture specific numbers in our runtime. If these APIs don't exist in metal, let's file an issue and get signoff from the metal team, should be relatively uncontroversial. Please tag any filed issues against metal on this issue.