search

tenstorrent / tt-mlir

Tenstorrent MLIR compiler
https://tenstorrent.github.io/tt-mlir/
Apache License 2.0
72 stars 9 forks source link

ttnn::empty doesn't work properly with tile layout #582

Open nsmithtt opened 2 months ago

nsmithtt commented 2 months ago

This issue tracks TODO comment:

ttnn::empty doesn't work properly with tile layout, using ROW_MAJOR until we fix it.

See PR #470 and commit dbd6fd27 for more context.

mrakitaTT commented 1 month ago

@tt-mpantic This is one of the issues that we would like to escalate to Metal team. Here is the link to metal issue: https://github.com/tenstorrent/tt-metal/issues/8635

It seems like an easy thing to fix, it seems that they are just not taking properly padding into consideration with the assertion they have. That issue is opened since May and it probably just fell through the cracks for them. Maybe some of us could help with fixing it.

It is causing us a lot of issues in compiler (more info here: https://github.com/tenstorrent/tt-mlir/issues/850#issuecomment-2388071979)

svuckovicTT commented 4 weeks ago

@tt-mpantic can you suggest the next step? I can't recall what the playbook is on metal bugs...