search

tenstorrent / tt-smi

Tenstorrent console based hardware information program
Apache License 2.0
21 stars 6 forks source link

Properly handle incorrect CLI arguments in tt-smi #15

Open hmohiuddinTT opened 6 months ago

hmohiuddinTT commented 6 months ago

Tried to run tt-rmi -r with multiple device ids but the program crashed. Should do some argparsing and fail gracefully with a cleaner error message.

image
sbansalTT commented 6 months ago

Looks like there is a device id 8 doesn't exist on the pci bus. Could you remove it and try again? But, I will also add a cleaner exit when the device isn't found - to make it easier for user to debug

hmohiuddinTT commented 6 months ago

Oh yeah I didn't even realize I added an extra device, but yeah we should still handle it gracefully.

warthog9 commented 5 months ago

more try/except blocks! ;-)